Skip to content

Ahoyapps 980 switch camera crash fix #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 5, 2021

Conversation

timmydoza
Copy link
Contributor

@timmydoza timmydoza commented Feb 3, 2021

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

This PR fixes an issue where the app crashes when the user tries to change their selected video device when their camera is off. Now the user can change video devices while their video is off. This works before you join a room, and while you are in a room.

This PR also fixes the alignment of the settings menu that you see in the gif here.

cam-crash

Closes #389

Burndown

Before review

  • Updated CHANGELOG.md if necessary
  • Added unit tests if necessary
  • Updated affected documentation
  • Verified locally with npm test
  • Manually sanity tested running locally
  • Included screenshot as PR comment (if needed)
  • Ready for review

Before merge

  • Got one or more +1s
  • Re-tested if necessary

@timmydoza timmydoza merged commit 0588594 into master Feb 5, 2021
@timmydoza timmydoza deleted the AHOYAPPS-980-switch-camera-crash-fix branch February 5, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop Video then try to change Video Input - Crash
2 participants