Skip to content

Change pinned Node.js version #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dkundel opened this issue Feb 24, 2020 · 2 comments · Fixed by #117
Closed

Change pinned Node.js version #111

dkundel opened this issue Feb 24, 2020 · 2 comments · Fixed by #117
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@dkundel
Copy link
Contributor

dkundel commented Feb 24, 2020

Right now the version we check for is pinned to 10.17.0. The cloud environment of Twilio Functions doesn't actually pin to a specific minor version anymore so we should change this to just check for 10.x.
@dkundel dkundel added good first issue Good for newcomers help wanted Extra attention is needed labels Feb 24, 2020
@badsketch
Copy link
Contributor

@dkundel I'd be interested in taking on this one 🙂

@dkundel
Copy link
Contributor Author

dkundel commented Mar 14, 2020

Yes please go ahead 😊

badsketch added a commit to badsketch/twilio-run that referenced this issue Mar 14, 2020
@badsketch
fix: changes pinned node version to 10.x
a1dc086 
Currently, we check if the node version is 10.17. Twilio Functions cloud no longer checks minor
versions so we only need to check for 10.x

fix twilio-labs#111
badsketch added a commit to badsketch/twilio-run that referenced this issue Mar 14, 2020
@badsketch
fix: changes pinned node version to 10.x
0c5635d 
Currently, we check if the node version is 10.17. Twilio Functions cloud no longer checks minor
versions so we only need to check for 10.x

fix twilio-labs#111
@badsketch badsketch mentioned this issue Mar 14, 2020
Merged
1 task
philnash added a commit that referenced this issue Mar 16, 2020
@philnash
Merge pull request #117 from badsketch/update-node-check
09e94a2 
fix: #111 change pinned node version to 10.x
@snyk-bot snyk-bot mentioned this issue Jul 15, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: #111 change pinned node version to 10.x badsketch/twilio-run
2 participants
@dkundel @badsketch