Cancel current query on cursor.close()
#195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hovaesco
reviewed
Jul 7, 2022
| def test_close_cursor(trino_connection): | ||
| cur = trino_connection.cursor() | ||
| cur.execute("SELECT * FROM tpch.sf1.customer") | ||
| cur.fetchone() # TODO (https://github.com./trinodb/trino/issues/2683) test with and without .fetchone |
There was a problem hiding this comment.
That particular issue is closed. I have tested the same code when omitting the cur.fetchone() the query is still cancelled, however it is not showing up in the Trino UI. I will remove the comment in a preparatory commit.
mdesmet
force-pushed
the
feature/cancel-query
branch
from
7605d46 to
9bb1466
Compare
hovaesco
approved these changes
Jul 7, 2022
ebyhr
approved these changes
Jul 7, 2022
mdesmet
force-pushed
the
feature/cancel-query
branch
from
9bb1466 to
00c4461
Compare
|
Merged, thanks! |
9 tasks
|
@ebyhr started having this problem with Trino installed in docker today, first time ever, never happened since I started the trino container. What should I do to resolve? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84