Skip to content

Drop Node 10 support #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MichaelDeBoey opened this issue May 16, 2021 · 4 comments · Fixed by #243
Closed

Drop Node 10 support #231

MichaelDeBoey opened this issue May 16, 2021 · 4 comments · Fixed by #243
Labels
BREAKING CHANGE This change will require a major version bump

Comments

@MichaelDeBoey
Copy link
Member

Because it's EOL.
@MichaelDeBoey MichaelDeBoey added the BREAKING CHANGE This change will require a major version bump label May 16, 2021
nickserv added a commit that referenced this issue Jul 6, 2021
@nickserv
Drop Node 10 support (fix #231)
3059808
@nickserv nickserv linked a pull request Jul 6, 2021 that will close this issue
feat: drop Node 10 support #243
Merged
@afontcu
Copy link
Member

afontcu commented Jul 26, 2021

Even though this is a breaking change, and given the fact that 6.x version range is reserved to support to Vue 3 (see #176), I think we should merge this one as a chore: so no version is issued, or maybe as a fix: so people can get a new version and handle any potential breaking change due to using node 10 (unlikely, I guess).

Thoughts?

@MichaelDeBoey
Copy link
Member Author

I would merge it together with Vue 3 support

@afontcu
Copy link
Member

afontcu commented Jul 27, 2021

Yeah, why not! I'll go ahead and change the base branch from the PR now

afontcu pushed a commit that referenced this issue Jul 30, 2021
@nickserv @afontcu
Drop Node 10 support (fix #231)
a8e29dc
afontcu pushed a commit that referenced this issue Aug 1, 2021
@nickserv @afontcu
Drop Node 10 support (fix #231)
865f930
@afontcu
Copy link
Member

afontcu commented Aug 1, 2021

fixed in #243

@afontcu afontcu closed this as completed Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BREAKING CHANGE This change will require a major version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: drop Node 10 support testing-library/vue-testing-library
2 participants
@MichaelDeBoey @afontcu