Use POSIX data types and macros #878

stweil · 2017-05-04T19:30:55Z

No description provided.

stweil · 2017-05-04T19:34:42Z

Ray, this commit has a high probability to conflict with your work, so please select single commits as you like or just tell me which changes can be applied next or when is the best time for such changes.

It would be good to finish the transformation to POSIX data types and macros in the not too far future.

stweil · 2017-05-05T15:33:33Z

Rebased PR to trigger a new AppVeyor build (previous build failed, reason unknown).

egorpugin · 2017-05-05T20:47:51Z

I'm working towards fast and not silent builds on appveyor, but it could take 1-2 month. (cppan related)
But it's possible that your commit really broke something on windows. (I did not do any cppan/appveyor changes during last 1-1.5 month.)

stweil · 2017-05-05T21:06:04Z

Could we just remove the i/o redirection in cmake --build . --config Release > bin\Release\log.txt? Writing compiler error messages to a file which cannot be read looks strange.

egorpugin · 2017-05-05T21:09:23Z

This will make build times up to near 1 hour or even 1+ which is impossible on appveyor.
There are too many warnings, so pushing all of them to stdout/err makes such slow build times.

stweil · 2017-05-05T21:45:20Z

Appveyor also supports caching. That could reduce build time significantly.

egorpugin · 2017-05-05T21:46:32Z

Nice. I'll investigate this, thanks!

stweil · 2017-05-06T06:42:37Z

Build now works. The previous errors were caused by ambiguous calls of ClipToRange.

Appveyor needed about 30 minutes total time with i/o redirection removed.

stweil · 2017-05-12T07:05:06Z

Fixed merge conflicts and rebased PR.

stweil · 2017-05-13T19:31:43Z

Fixed merge conflicts and rebased PR.

stweil · 2017-05-17T19:43:10Z

Fixed merge conflicts and rebased PR.

stweil · 2017-07-13T08:19:29Z

@theraysmith, as you are just preparing a new larger code change: is it possible to use POSIX data types for the new / modified code, and can we switch to POSIX for the rest of the code directly after your update?

theraysmith · 2017-07-13T16:19:15Z

The best time to switch to POSIX types is after the legacy engine is removed, otherwise it is just a waste of time merging it and reviewing it.

…

On Thu, Jul 13, 2017 at 1:19 AM, Stefan Weil ***@***.***> wrote: @theraysmith <https://github.com./theraysmith>, as you are just preparing a new larger code change: is it possible to use POSIX data types for the new / modified code, and can we switch to POSIX for the rest of the code directly after your update? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#878 (comment)>, or mute the thread <https://github.com./notifications/unsubscribe-auth/AL056WoPKurkhF6p7FaQbU71cN6cqaAfks5sNdMigaJpZM4NRHiF> .

-- Ray.

stweil · 2017-07-24T18:51:43Z

Rebased PR and fixed merge conflicts.

Signed-off-by: Stefan Weil <[email protected]>

Now all Tesseract data types which are no longer needed can be removed from ccutil/host.h. Signed-off-by: Stefan Weil <[email protected]>

…INT*_MAX Signed-off-by: Stefan Weil <[email protected]>

… *INT*_MAX Signed-off-by: Stefan Weil <[email protected]>

…T*_MAX Signed-off-by: Stefan Weil <[email protected]>

…*INT*_MAX Signed-off-by: Stefan Weil <[email protected]>

…INT*_MAX Remove the macros which are now unused from ccutil/host.h. Remove also the obsolete history comments. Signed-off-by: Stefan Weil <[email protected]>

Signed-off-by: Stefan Weil <[email protected]>

Error message vom Appveyor CI: C:\projects\tesseract\ccstruct\coutln.cpp(818): error C2672: 'ClipToRange': no matching overloaded function found [C:\projects\tesseract\build\libtesseract.vcxproj] C:\projects\tesseract\ccstruct\coutln.cpp(818): error C2782: 'T ClipToRange(const T &,const T &,const T &)': template parameter 'T' is ambiguous [C:\projects\tesseract\build\libtesseract.vcxproj] c:\projects\tesseract\ccutil\helpers.h(122): note: see declaration of 'ClipToRange' C:\projects\tesseract\ccstruct\coutln.cpp(818): note: could be 'char' C:\projects\tesseract\ccstruct\coutln.cpp(818): note: or 'int' Signed-off-by: Stefan Weil <[email protected]>

Signed-off-by: Stefan Weil <[email protected]>

stweil · 2018-03-13T18:22:04Z

Fixed merge conflicts and rebased.

zdenop · 2018-03-13T20:13:42Z

Can this be merge now?

stweil · 2018-03-13T20:21:43Z

That would be great! But what about Ray's comment (see above)?

zdenop · 2018-03-13T20:35:51Z

He promised to deliver code beginning of August 2017... ;-) And based on Jeff info there will be no new code soon...

stweil force-pushed the posix branch from 0ad5305 to 5e64f64 Compare May 5, 2017 15:31

stweil force-pushed the posix branch from 5e64f64 to 326e6e0 Compare May 5, 2017 21:08

stweil force-pushed the posix branch 2 times, most recently from d2c98c5 to 70b2875 Compare May 6, 2017 06:08

stweil force-pushed the posix branch from 70b2875 to db865aa Compare May 6, 2017 18:06

stweil mentioned this pull request May 9, 2017

Too many warnings! #896

Merged

stweil force-pushed the posix branch 3 times, most recently from 4a956c6 to 9e832e4 Compare May 12, 2017 07:04

stweil force-pushed the posix branch from 9e832e4 to 9f06300 Compare May 13, 2017 19:30

stweil force-pushed the posix branch 4 times, most recently from a0cea41 to b123142 Compare May 17, 2017 19:41

stweil force-pushed the posix branch from b123142 to 687c9a4 Compare May 23, 2017 05:35

stweil force-pushed the posix branch from 687c9a4 to 34f4d53 Compare July 24, 2017 18:51

stweil mentioned this pull request Mar 3, 2018

Use POSIX data types for external interfaces #1358

Merged

stweil added 21 commits March 13, 2018 19:18

api: Replace Tesseract data types by POSIX data types

11f22fe

Signed-off-by: Stefan Weil <[email protected]>

ccmain: Replace Tesseract data types by POSIX data types

c9bbeb8

Signed-off-by: Stefan Weil <[email protected]>

ccstruct: Replace Tesseract data types by POSIX data types

d311c37

Signed-off-by: Stefan Weil <[email protected]>

classify: Replace Tesseract data types by POSIX data types

b6b9fd4

Signed-off-by: Stefan Weil <[email protected]>

cutil: Replace Tesseract data types by POSIX data types

76f7d17

Signed-off-by: Stefan Weil <[email protected]>

dict: Replace Tesseract data types by POSIX data types

6061f85

Signed-off-by: Stefan Weil <[email protected]>

textord: Replace Tesseract data types by POSIX data types

a7f129e

Signed-off-by: Stefan Weil <[email protected]>

training: Replace Tesseract data types by POSIX data types

58f7eea

Signed-off-by: Stefan Weil <[email protected]>

wordrec: Replace Tesseract data types by POSIX data types

dcef761

Signed-off-by: Stefan Weil <[email protected]>

ccutil: Replace Tesseract data types by POSIX data types

92a62eb

Now all Tesseract data types which are no longer needed can be removed from ccutil/host.h. Signed-off-by: Stefan Weil <[email protected]>

ccmain: Replace Tesseract's MIN_*INT, MAX_*INT* by POSIX *INT*_MIN, *…

57dffb1

…INT*_MAX Signed-off-by: Stefan Weil <[email protected]>

ccstruct: Replace Tesseract's MIN_*INT, MAX_*INT* by POSIX *INT*_MIN,…

1741341

… *INT*_MAX Signed-off-by: Stefan Weil <[email protected]>

classify: Replace Tesseract's MIN_*INT, MAX_*INT* by POSIX *INT*_MIN,…

4ebe75d

… *INT*_MAX Signed-off-by: Stefan Weil <[email protected]>

dict: Replace Tesseract's MIN_*INT, MAX_*INT* by POSIX *INT*_MIN, *IN…

cfb3ac4

…T*_MAX Signed-off-by: Stefan Weil <[email protected]>

lstm: Replace Tesseract's MIN_*INT, MAX_*INT* by POSIX *INT*_MIN, *IN…

d589c64

…T*_MAX Signed-off-by: Stefan Weil <[email protected]>

textord: Replace Tesseract's MIN_*INT, MAX_*INT* by POSIX *INT*_MIN, …

3698d22

…*INT*_MAX Signed-off-by: Stefan Weil <[email protected]>

wordrec: Replace Tesseract's MIN_*INT, MAX_*INT* by POSIX *INT*_MIN, …

e3e6640

…*INT*_MAX Signed-off-by: Stefan Weil <[email protected]>

ccutil: Replace Tesseract's MIN_*INT, MAX_*INT* by POSIX *INT*_MIN, *…

fa8b583

…INT*_MAX Remove the macros which are now unused from ccutil/host.h. Remove also the obsolete history comments. Signed-off-by: Stefan Weil <[email protected]>

unittest: Replace Tesseract's MAX_INT8 by POSIX INT8_MAX

2ba522b

Signed-off-by: Stefan Weil <[email protected]>

arch: Replace Tesseract's MAX_INT8 by POSIX INT8_MAX

c6c5d65

Signed-off-by: Stefan Weil <[email protected]>

stweil force-pushed the posix branch from bc9468e to c6c5d65 Compare March 13, 2018 18:21

zdenop merged commit 023e1b3 into tesseract-ocr:master Mar 13, 2018

stweil deleted the posix branch March 14, 2018 13:55

amitdo added the modernize label Mar 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use POSIX data types and macros #878

Use POSIX data types and macros #878

stweil commented May 4, 2017

stweil commented May 4, 2017 •

edited

Loading

stweil commented May 5, 2017

egorpugin commented May 5, 2017 •

edited

Loading

stweil commented May 5, 2017

egorpugin commented May 5, 2017

stweil commented May 5, 2017

egorpugin commented May 5, 2017

stweil commented May 6, 2017

stweil commented May 12, 2017

stweil commented May 13, 2017

stweil commented May 17, 2017

stweil commented Jul 13, 2017

theraysmith commented Jul 13, 2017 via email

stweil commented Jul 24, 2017

stweil commented Mar 13, 2018

zdenop commented Mar 13, 2018

stweil commented Mar 13, 2018

zdenop commented Mar 13, 2018

Use POSIX data types and macros #878

Use POSIX data types and macros #878

Conversation

stweil commented May 4, 2017

stweil commented May 4, 2017 • edited Loading

stweil commented May 5, 2017

egorpugin commented May 5, 2017 • edited Loading

stweil commented May 5, 2017

egorpugin commented May 5, 2017

stweil commented May 5, 2017

egorpugin commented May 5, 2017

stweil commented May 6, 2017

stweil commented May 12, 2017

stweil commented May 13, 2017

stweil commented May 17, 2017

stweil commented Jul 13, 2017

theraysmith commented Jul 13, 2017 via email

stweil commented Jul 24, 2017

stweil commented Mar 13, 2018

zdenop commented Mar 13, 2018

stweil commented Mar 13, 2018

zdenop commented Mar 13, 2018

stweil commented May 4, 2017 •

edited

Loading

egorpugin commented May 5, 2017 •

edited

Loading