Skip to content
This repository was archived by the owner on Jul 1, 2023. It is now read-only.

Adding GlobalAveragePooling1D #66

Merged
merged 3 commits into from
Apr 1, 2019
Merged

Adding GlobalAveragePooling1D #66

merged 3 commits into from
Apr 1, 2019

Conversation

Shashi456
Copy link
Contributor

So I'm relatively new to the swift ecosystem, let me know if there are any errors. Afaik my understanding of GlobalAveragePooling in a single dimension is returning the mean * the no of batches if it's a multi-batch input.

@rxwei rxwei self-requested a review March 30, 2019 09:53
Co-Authored-By: Shashi456 <[email protected]>
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@rxwei
Copy link
Contributor

rxwei commented Apr 1, 2019

Did you sign the CLA?

@Shashi456
Copy link
Contributor Author

@rxwei yeah i have

/// A global average pooling layer for temporal data.
@_fixed_layout
public struct GlobalAveragePooling1D<Scalar: TensorFlowFloatingPoint>: Layer {
/// Creates a global average pooling layer in 1 dimension
Copy link
Contributor

@rxwei rxwei Apr 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// Creates a global average pooling layer in 1 dimension
/// Creates a global average pooling layer.
  • Please end sentences with a period.
  • Remove "in 1 dimension" to be consistent with the doc comment on the type declaration.

@rxwei rxwei merged commit 2a8d756 into tensorflow:master Apr 1, 2019
@Shashi456 Shashi456 deleted the layer branch April 2, 2019 04:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants