-
Notifications
You must be signed in to change notification settings - Fork 137
Conversation
Co-Authored-By: Shashi456 <[email protected]>
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
Did you sign the CLA? |
@rxwei yeah i have |
Sources/DeepLearning/Layer.swift
Outdated
/// A global average pooling layer for temporal data. | ||
@_fixed_layout | ||
public struct GlobalAveragePooling1D<Scalar: TensorFlowFloatingPoint>: Layer { | ||
/// Creates a global average pooling layer in 1 dimension |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/// Creates a global average pooling layer in 1 dimension | |
/// Creates a global average pooling layer. |
- Please end sentences with a period.
- Remove "in 1 dimension" to be consistent with the doc comment on the type declaration.
So I'm relatively new to the swift ecosystem, let me know if there are any errors. Afaik my understanding of GlobalAveragePooling in a single dimension is returning the mean * the no of batches if it's a multi-batch input.