fix!: Use plain Error in FailureConverter, WorkflowFailedError, and WorkflowUpdateFailedError #1685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergundy
force-pushed
the
failure-converter-error
branch
from
b23851e to
7faa559
Compare
THardy98
approved these changes
Apr 21, 2025
bergundy
force-pushed
the
failure-converter-error
branch
from
7faa559 to
525a4f3
Compare
bergundy
added a commit
to temporalio/features
that referenced
this pull request
Apr 21, 2025
See related change: temporalio/sdk-typescript#1685 Also upgraded Go in docker image to ensure the Go image build action passes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💥 BREAKING CHANGE 💥
Instead of expecting that the FailureConverter will always return a TemporalFailure.
This change is required for the FailureConverter to support Nexus HandlerError.
NOTE: a similar breaking change has been made in the Java SDK a little while ago: temporalio/sdk-java#2365