Skip to content

Add support for dimension prefix when using dynamic min-* and max-* #11217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions src/util/buildMediaQuery.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,23 @@
/**
* @param {string} value
* @returns {[string, string]}
*/
export function splitVariantPrefix(value) {
if (typeof value !== 'string') return ['', value]
let parts = value.split(':')
return ['', ...parts].slice(-2)
}

/**
* @param {string} value
* @returns {[string, string]}
*/
function splitDimensionPrefix(value) {
const [prefix, extractedValue] = splitVariantPrefix(value)
const dimension = prefix === 'h' ? 'height' : 'width'
return [dimension, extractedValue]
}

export default function buildMediaQuery(screens) {
screens = Array.isArray(screens) ? screens : [screens]

Expand All @@ -8,9 +28,12 @@ export default function buildMediaQuery(screens) {
return screen.raw
}

let [minDimension, minValue] = splitDimensionPrefix(screen.min)
let [maxDimension, maxValue] = splitDimensionPrefix(screen.max)

return [
screen.min && `(min-width: ${screen.min})`,
screen.max && `(max-width: ${screen.max})`,
minValue && `(min-${minDimension}: ${minValue})`,
maxValue && `(max-${maxDimension}: ${maxValue})`,
]
.filter(Boolean)
.join(' and ')
Expand Down
102 changes: 102 additions & 0 deletions tests/min-max-screen-variants.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,108 @@ crosscheck(() => {
})
})

it('supports min-* and max-* variants with or without arbitrary dimension prefixes', () => {
let config = {
content: [
{
raw: html`
<div
class="font-bold min-[100px]:font-bold max-[100px]:font-bold min-[w:100px]:font-bold max-[w:100px]:font-bold min-[h:100px]:font-bold max-[h:100px]:font-bold"
></div>
`,
},
],
corePlugins: { preflight: false },
theme: {
screens: defaultScreens,
},
}

let input = css`
@tailwind utilities;
`

return run(input, config).then((result) => {
expect(result.css).toMatchFormattedCss(css`
.font-bold {
font-weight: 700;
}
@media (max-width: 100px) {
.max-\[100px\]\:font-bold {
font-weight: 700;
}
}
@media (max-height: 100px) {
.max-\[h\:100px\]\:font-bold {
font-weight: 700;
}
}
@media (max-width: 100px) {
.max-\[w\:100px\]\:font-bold {
font-weight: 700;
}
}
@media (min-width: 100px) {
.min-\[100px\]\:font-bold {
font-weight: 700;
}
}
@media (min-height: 100px) {
.min-\[h\:100px\]\:font-bold {
font-weight: 700;
}
}
@media (min-width: 100px) {
.min-\[w\:100px\]\:font-bold {
font-weight: 700;
}
}
`)
})
})

it('supports min-* and max-* variants being used together with or without arbitrary dimension prefixes', () => {
let config = {
content: [
{
raw: html`
<div
class="min-[100px]:min-[w:100px]:min-[h:100px]:max-[100px]:max-[w:100px]:max-[h:100px]:font-bold"
></div>
`,
},
],
corePlugins: { preflight: false },
theme: {
screens: defaultScreens,
},
}

let input = css`
@tailwind utilities;
`

return run(input, config).then((result) => {
expect(result.css).toMatchFormattedCss(css`
@media (min-width: 100px) {
@media (min-width: 100px) {
@media (min-height: 100px) {
@media (max-width: 100px) {
@media (max-width: 100px) {
@media (max-height: 100px) {
.min-\[100px\]\:min-\[w\:100px\]\:min-\[h\:100px\]\:max-\[100px\]\:max-\[w\:100px\]\:max-\[h\:100px\]\:font-bold {
font-weight: 700;
}
}
}
}
}
}
}
`)
})
})

it('warns when using min variants with complex screen configs', async () => {
let config = {
content: [
Expand Down