Skip to content

Add note about 'phar extension' dependency #5963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add note about 'phar extension' dependency #5963

wants to merge 2 commits into from

Conversation

snoek09
Copy link

@snoek09 snoek09 commented Dec 5, 2015

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets #5919

@xabbuh
Copy link
Member

xabbuh commented Dec 9, 2015

👍

@javiereguiluz
Copy link
Member

I agree with adding this note ... but I'm not sure about the wording.

In my opinion, the problem is that you are telling the users: "hey, do this and check this before executing the command". Problem is that most of our users won't have this issue (because PHAR is usually enabled) and a lot of newcomers don't know where or how to check for this "strange" phar extension. So we should avoid telling them to check anything before executing the command.

If we reword the note as follows, most of these issue would be solved:

If the installer doesn't work for you or doesn't output anything, make sure
that the `PHP phar extension`_ is installed and enabled in your computer.

wouterj added a commit that referenced this pull request Dec 17, 2015
This PR was squashed before being merged into the 2.3 branch (closes #5963).

Discussion
----------

Add note about 'phar extension' dependency

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | #5919

Commits
-------

696c154 Add note about 'phar extension' dependency
@wouterj
Copy link
Member

wouterj commented Dec 17, 2015

Thank you @snoek09 for adding this little helpfull note!

Now we changed the content of the note, I've moved it below the code example executing the symfony installer, as I think that makes more sense. I've also copied the note to the Installation documentation, where we mention the installer as well. See 709fc61.

Also, what do we think about adding a little command one can execute to check if the extension is available? E.g. php -r "echo extension_loaded('phar');".

@wouterj wouterj closed this Dec 17, 2015
@snoek09 snoek09 deleted the add-phar-extension-note branch January 19, 2016 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants