Removed literals for bundle names #4865
Conversation
|
I tend to agree with you |
| @@ -45,7 +45,7 @@ and put things there: | |||
|
|
|||
| .. tip:: | |||
|
|
|||
| The recommended approach of using the ``AppBundle`` directory is for | |||
| The recommended approach of using the AppBundle directory is for | |||
There was a problem hiding this comment.
AppBundle refers to a directory name.
There was a problem hiding this comment.
Good catch! I've changed it to AppBundle/ to make it even more clear
|
👍 (besides the two minor things I commented on) |
wouterj
force-pushed
the
remove_literal_bundle_names
branch
from
2f95773 to
f361c87
Compare
|
@weaverryan before merging, I first want your opinion on this :) |
| the ``AcmeHelloBundle`` bundle. This helps you specify the path to the resource | ||
| without worrying later if you move the ``AcmeHelloBundle`` to a different | ||
| directory. | ||
| file. The special ``@AcmeHello`` syntax resolves the directory path of the |
There was a problem hiding this comment.
This is (and was) a typo, right? Should be @AcmeHelloBundle
There was a problem hiding this comment.
Fixed at sha: b624100 - someone tackle me if I'm missing something :)
|
@wouterj Hmm, I like your point - the literals make things stand out, which can be bad for reading. So I definitely support this! In some cases, the bundle is referring to a directory, and in that case it should still have the literals. But I noticed that you did exactly this in your PR, so nice work :). |
This PR was merged into the 2.3 branch. Discussion ---------- Removed literals for bundle names *Note: Most of it was automated and I didn't review it closely yet (since I didn't know the general opinion on this topic), so there can be some faulty changes.* I always like to use as less literals as possible, as I think it makes sentences harder to understand. That's why I strongly believe that literals should exclusively be used for code. As a bundle name is not code, I propose to remove all literals around bundle names. | Q | A | --- | --- | Doc fix? | yes | New docs? | nope | Applies to | all | Fixed tickets | - Commits ------- f361c87 Removed literals for bundle names
javiereguiluz
added
Waiting feedback
and removed
Waiting feedback
needs comments
labels
Note: Most of it was automated and I didn't review it closely yet (since I didn't know the general opinion on this topic), so there can be some faulty changes.
I always like to use as less literals as possible, as I think it makes sentences harder to understand. That's why I strongly believe that literals should exclusively be used for code. As a bundle name is not code, I propose to remove all literals around bundle names.