-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Fix use mistakes #4120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix use mistakes #4120
Conversation
Wow, you've gone use statement hunting! Nice job of fixing some of the examples! Some tips for the next time you create PRs (you don't have to edit this PR, it's just in case you want to contribute more):
To comment on your question:
In the definition of the |
@@ -104,6 +104,8 @@ Asset path generation is handled internally by packages. The component provides | |||
|
|||
You can also use multiple packages:: | |||
|
|||
use Symfony\Component\Templating\Asset\PathPackage; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we add a use
statement for the PathPackage
class, we should also add one for the AssetsHelper
.
@mbutkereit @wouterj What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree, that is already covered by the // ...
Thanks for making these changes @mbutkereit - you rock! |
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #4120). Discussion ---------- Fix use mistakes | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all On http://symfony.com/doc/current/components/config/resources.html at "new YamlUserLoader", we have also a missing "use" statement. But i'm not sure if we need there one. Commits ------- 7016c82 Fixing a mistake 4353d1f Fix use mistakes.
On http://symfony.com/doc/current/components/config/resources.html at "new YamlUserLoader", we have also a missing "use" statement. But i'm not sure if we need there one.