-
Notifications
You must be signed in to change notification settings - Fork 339
[lldb/Host] Remove TaskPool and replace its uses with llvm::ThreadPool #1576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The head ref may contain hidden characters: "\u{1F352}/e57361c055d7617ee25cdac8167625000d098ef5"
[lldb/Host] Remove TaskPool and replace its uses with llvm::ThreadPool #1576
Conversation
Remove LLDB's TaskPool and replace its uses with LLVM's ThreadPool. Differential revision: https://reviews.llvm.org/D78337 (cherry picked from commit e57361c)
@swift-ci please test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 😄
I don't see the REPL test timeouts locally and I can't think of any reason this change would cause that. Let's try again... @swift-ci please test platform macos |
@swift-ci please test macos platform |
After a few tries I was able to repro this. It appears like a legit deadlock. We're waiting on the module mutex in
I'll need to do a debug build to be sure, but I suspect it's the same module as the one held by the
|
This was already worked around in rdar://problem/38461035, but it was lost in a follow-up merge resolution. This reinstates the workaround and adds a test (from https://bugs.swift.org/browse/SR-7114) to make sure we don't regress this. apple-llvm-split-commit: ac73e28ffd7b156abbc6a9b3b62db0ba3b4c46f2 apple-llvm-split-dir: lldb/ (cherry picked from commit 510589b)
@swift-ci please test |
Remove LLDB's TaskPool and replace its uses with LLVM's ThreadPool.
Differential revision: https://reviews.llvm.org/D78337
(cherry picked from commit e57361c)