Skip to content

Improve useVitePreprocess #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Sep 29, 2021
Merged

Improve useVitePreprocess #173

merged 18 commits into from
Sep 29, 2021

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Sep 20, 2021

When enabling useVitePreprocess, importsNotUsedAsValues: "preserve" won't be forced on the entire codebase, only in Svelte files.

@dummdidumm
Copy link
Member

What is the use case for this? Getting rid of the need to use svelte-preprocess when you use TypeScript and nothing else?

@bluwy
Copy link
Member Author

bluwy commented Sep 21, 2021

Yes, and also when using css preprocessors like scss and stylus. Typescript would be handled with Vite's own esbuild instance so it would replace the need for svelte-preprocess-esbuild. Css preprocessors config can be shared via the Vite config too.

There is still use cases for svelte-preprocess though, like the recent TypeScript improvements, or it's more advanced preprocessing for style tags.

@bluwy bluwy force-pushed the feat/improve-usevitepreprocess branch from 8feee11 to 72441c2 Compare September 29, 2021 07:52
@bluwy bluwy marked this pull request as ready for review September 29, 2021 07:53
@dominikg dominikg merged commit 847077d into main Sep 29, 2021
@dominikg dominikg deleted the feat/improve-usevitepreprocess branch September 29, 2021 08:22
@github-actions github-actions bot mentioned this pull request Sep 29, 2021
@github-actions github-actions bot mentioned this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants