Skip to content

fix: correctly validate undefined snippet params with default value #15750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 12, 2025

Conversation

paoloricciuti
Copy link
Member

Closes #15749

Technically we could've avoid all the fallback_idx conundrum and just allow undefined too but this should be more correct most of the times and it's not really a problem since it's mostly in dev. I also thought of using a Set instead of an array but it's not really worth it since there will never be a lot of params anyway.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com./sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Apr 12, 2025

🦋 Changeset detected

Latest commit: da36864

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@15750

@Rich-Harris
Copy link
Member

we can simplify this by just using arguments — will push a change

@Rich-Harris Rich-Harris merged commit 69a4275 into main Apr 12, 2025
13 checks passed
@Rich-Harris Rich-Harris deleted the validate-undefined-snippet-param-with-default branch April 12, 2025 14:39
@github-actions github-actions bot mentioned this pull request Apr 12, 2025
@paoloricciuti
Copy link
Member Author

Uh that's frickin smart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snippet invocation fails if default value of argument used instead of passing argument
2 participants