remove non-browser code from browser builds #7296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0a1b62e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dummdidumm
approved these changes
Oct 18, 2022
dummdidumm
reviewed
Oct 18, 2022
| @@ -2,6 +2,9 @@ import * as assert from 'uvu/assert'; | |||
| import { describe } from './unit_test.js'; | |||
| import { resolve, normalize_path, make_trackable, disable_search } from './url.js'; | |||
|
|
|||
| // @ts-expect-error define global required in url.js | |||
| globalThis.__SVELTEKIT_BROWSER__ = false; | |||
There was a problem hiding this comment.
didn't find a better way to achieve this. Using uvu's -r somefile.js doesn't work because that somehow switches everything to using require, which fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small thing but I noticed we're including this code in production client builds, quite unnecessarily. There might be other cases, and after this PR we can just wrap them in a
if (!__SVELTEKIT_BROWSER__)block to remove them from client builds.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0