-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
sync: account for relative route path #7223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Currently when using relative route path in `config.kit.files.routes` e.g. `../../project/src/routes` sync fails because it generates types outside of `.svelte-kit/types` It should account for relative paths and generate them inside `.svelte-kit/types`
🦋 Changeset detectedLatest commit: 9b65038 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Thanks! Could you add a changeset? Also, to be sure: Does this really fix the mentioned issue completely? You talk about some manifest not being found there, and the changed code is only related to generating types. |
The issue was, if I wasn't using relative path for routes, sync was passing but build was failing due to wrong paths. But if I want to change routes path to match vite manifest (it always resolves to relative path), it was creating it in wrong place due to being relative and sync was filing and not creating |
Currently when using relative route path in
config.kit.files.routes
e.g.../../project/src/routes
sync fails because it generates types outside of.svelte-kit/types
It should account for relative paths and generate them inside.svelte-kit/types
fixes: #7166
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0