Skip to content

fix: Generated types no longer permanently delete themselves #5063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

elliott-with-the-longest-name-on-github
Copy link
Contributor

Fixes #5059.

svelte-kit sync always completely deletes the types directory when it writes types. Then, it re-writes types by looking for changed files. If no files have been changed, the types directory is gone for good (or at least until a file is changed). See the repro in the linked issue.

This fixes the issue by always rewriting all of the types (since we're deleting everything, we need to rewrite everything). I'm not really sure how to test this change, though this does fix the repro.

If there's some larger issue here that needs a bigger fix, feel free to just close this and move on!

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com./sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented May 24, 2022

🦋 Changeset detected

Latest commit: 8a351a4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit c936eb8 into sveltejs:master May 24, 2022
@Rich-Harris
Copy link
Member

thank you!

@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github deleted the sejohnson-fix-generated-types branch May 24, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated types for all files are deleted and never repopulated when sync is run
2 participants