Fluffy: Simplify and optimize ContentDb pruning #3163
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdeme
commented
Mar 25, 2025
| # dataRadius, so the radius will constantly decrease through the node its | ||
| # lifetime. | ||
| db.dataRadius = newRadius | ||
| while db.usedSize() >= int64(db.storageCapacity): |
There was a problem hiding this comment.
I don't fully like that we have to do a while loop here, but else there might be situations where nothing or not enough content gets deleted.
Simplify by shrinking the data radius with 5% and just deleting all content that no longer falls within that range. This gives roughly a 150x speed improvement on a 4GB database. The downside is that we cannot be certain that a single 5% radius drop will result in a similar storage drop.
kdeme
force-pushed
the
simplify-contentdb-pruning
branch
from
af5fcfa to
68bd7bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify by shrinking the data radius with 5% and just deleting all content that no longer falls within that range.
This gives roughly a 150x speed improvement on a 4GB database. The downside is that we cannot be certain that a single 5% radius drop will result in a similar storage drop.