Skip to content

bugfix: add extraEnvs to splunk-operator helm-chart #1490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

bugfix: add extraEnvs to splunk-operator helm-chart #1490

wants to merge 1 commit into from

Conversation

patrykw-splunk
Copy link
Collaborator

Linked issue #1478

This PR introduces extraEnvs list to splunk-operator's values.yaml. This field is used by deployment.yaml template to inject custom envs provided by users.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 14533342230

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.008%) to 86.613%
Files with Coverage Reduction New Missed Lines %
pkg/splunk/enterprise/cp.go 1 33.33%
Totals Coverage Status
Change from base Build 14516261126: -0.008%
Covered Lines: 10546
Relevant Lines: 12176
💛 - Coveralls

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 14533342240

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.621%
Totals Coverage Status
Change from base Build 14516261126: 0.0%
Covered Lines: 10547
Relevant Lines: 12176
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlieberman-splunk rlieberman-splunk rlieberman-splunk approved these changes

@kasiakoziol kasiakoziol kasiakoziol approved these changes

@vivekr-splunk vivekr-splunk Awaiting requested review from vivekr-splunk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patrykw-splunk @coveralls @rlieberman-splunk @kasiakoziol