Fix monkey patch of ActiveRecord::Base for records without primary key #282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
On the project I am working on, we are relying on TimescaleDB PostgreSQL extension.
The corresponding hypertables and record implementation does not expose a
primary_key
attribute on the record class nor does it have anid
at the instance level.This means that all calls to
attributes_for_super_diff
result withNoMethodError: undefined method
to_sym' for nil`.Fix
This PR proposes to edit the monkey patch to handle this specific case.