Skip to content

Tests: uncover a quirk in our linkcheck tests #13466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jayaddison
Copy link
Contributor

Purpose

This change only affects our test suite; it exposes a quirk in behaviour as a result of an event-based call to the compile_linkcheck_allowed_redirects method (a fairly self-descriptive method).

This is a limitation of our linkcheck testsuite; some test cases may unwittingly rely on the compilation step.

Had this compilation been in place - reflecting how a sphinx-build -b linkcheck ... session would usually proceed -- then tests would have begun failing with the merge of #13452.

I think it suggests an unexpected change-in-default behaviour; confirming that tests fail for this PR could help to demonstrate the problem and discuss it.

References

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant