Tests: uncover a quirk in our linkcheck tests #13466
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This change only affects our test suite; it exposes a quirk in behaviour as a result of an event-based call to the
compile_linkcheck_allowed_redirects
method (a fairly self-descriptive method).This is a limitation of our
linkcheck
testsuite; some test cases may unwittingly rely on the compilation step.Had this compilation been in place - reflecting how a
sphinx-build -b linkcheck ...
session would usually proceed -- then tests would have begun failing with the merge of #13452.I think it suggests an unexpected change-in-default behaviour; confirming that tests fail for this PR could help to demonstrate the problem and discuss it.
References
linkcheck_allowed_redirects
is an empty dictionary #13452.