Skip to content

Use refdomain='std' for pending_xref() on Sphinx >= 1.6 #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 13, 2018
Merged

Conversation

mgeier
Copy link
Member

@mgeier mgeier commented May 2, 2017

@mgeier
Copy link
Member Author

mgeier commented May 3, 2017

This seems to be a backward-incompatible change and it will hopefully be fixed in Sphinx: sphinx-doc/sphinx#3698.

@mgeier
Copy link
Member Author

mgeier commented May 3, 2017

For now, this is fixed in sphinx-doc/sphinx#3699, but it will break again in Sphinx 2.0.
Some time before that (but not too soon), we should merge this PR.

@mgeier mgeier changed the title Always use refdomain='std' for pending_xref() Use refdomain='std' for pending_xref() on Sphinx >= 1.6 Jul 13, 2018
@mgeier
Copy link
Member Author

mgeier commented Jul 13, 2018

I've added a check for the Sphinx version. Now it should work on old and new versions.

@mgeier mgeier merged commit afbe1d7 into master Jul 13, 2018
@mgeier mgeier deleted the pending-xref branch July 13, 2018 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant