Skip to content

Update messageStore.js to fix Issue:It it duplicating the self messag… #5341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: examples/private-messaging-part-4
Choose a base branch
from

Conversation

MeeeeetShah
Copy link

…es after refreshing the window in examples/private messages #5340

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current behavior

It's duplicate the message in redis store for self messages due to no condition checks

New behavior

It resolved by just adding a simple condition

Other information (e.g. related issues)

…es after refreshing the window in examples/private messages socketio#5340
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant