Fix doc-test in consensus crate
#6561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 9f657b0 |
michaelsproul
added
ready-for-merge
|
Good catch. Based on a quick search it looks like nextest doesn't support running doctests, so maybe we should add a separate step just for them. Although I can imagine this might be almost 2x slower :\ |
5 tasks
chong-he
pushed a commit
to chong-he/lighthouse
that referenced
this pull request
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
I ran
make testrecently and noticed I was getting a doc-test failure in theconsensuscrate.Proposed Changes
Updates the import inside the doc test to use the correct crate.
Additional Info
Curious to know why CI didn't catch this. To me that seems to indicate that
make nextest-releasedoesn't cover the same set of tests asmake test