Skip to content

chore: prepare lint script for no-unused-vars #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

DonIsaac
Copy link
Contributor

@DonIsaac DonIsaac commented Aug 22, 2024

πŸ”— Linked issue

Not Applicable

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR explicitly denies violations of no-unused-vars for oxlint.

We are planning on bringing no-unused-vars out of our nursery category and making it a correctness rule in the near future. This PR will help ensure this does not break your CI. Thank you for using oxlint.

note: I am the product manager for oxlint

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@zoey-kaiser
Copy link
Member

Hi @DonIsaac πŸ‘‹

Thanks for the PR and the amazing work on oxlint!

@zoey-kaiser zoey-kaiser merged commit c5a62d9 into sidebase:main Aug 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants