Skip to content

feat: Add httpOnly cookie attribute support #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 8, 2024

Conversation

maximehamou
Copy link
Contributor

@maximehamou maximehamou commented Aug 8, 2024

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Added httpOnly attribute support for local and refresh providers + updated the docs accordingly

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

phoenix-ru
phoenix-ru previously approved these changes Aug 8, 2024
@phoenix-ru
Copy link
Collaborator

@maximehamou Could you please fix lint issues? Aside from that, code lgtm

@maximehamou
Copy link
Contributor Author

@maximehamou Could you please fix lint issues?

No problem, I will shortly.

However, I think it’s a little bit trickier than expected regarding how the update works. After further tests, the cookie is not saved. If I set httpOnlyCookieAttribute to false, and I force httpOnly with the checkbox in storage section, I couldn't log out anymore...

@zoey-kaiser zoey-kaiser changed the title feat: Add httpOnly attribute support feat: Add httpOnly cookie attribute support Aug 8, 2024
@zoey-kaiser zoey-kaiser added provider-local An issue with the local provider provider-refresh An issue with the refresh provider labels Aug 8, 2024
@zoey-kaiser zoey-kaiser merged commit d1d33e9 into sidebase:main Aug 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider-local An issue with the local provider provider-refresh An issue with the refresh provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants