Skip to content

fix: add set-cookie header for each set-cookie #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 18, 2024

Conversation

hitochan777
Copy link
Contributor

@hitochan777 hitochan777 commented Apr 4, 2024

πŸ”— Linked issue

#725

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@hitochan777
Copy link
Contributor Author

@zoey-kaiser I know you are busy, but could you please take some time to review my code?

@zoey-kaiser
Copy link
Member

@zoey-kaiser I know you are busy, but could you please take some time to review my code?

@phoenix-ru will do a review today! Then we can move forward. Thank you for your patience 😊

@phoenix-ru
Copy link
Collaborator

@hitochan777 Brilliant work! Thanks for a thorough issue documentation in #725 and for providing a reproduction repository, these really helped

Merging your code and we'll do a patch release soon

@phoenix-ru phoenix-ru merged commit 93e63a6 into sidebase:main Apr 18, 2024
4 checks passed
@hitochan777 hitochan777 deleted the fix-multiple-set-cookie-joined branch April 19, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants