-
-
Notifications
You must be signed in to change notification settings - Fork 177
fix: addDefaultCallback can be set with refresh and local providers #710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: addDefaultCallback can be set with refresh and local providers #710
Conversation
Hi @nojiritakeshi π Thank you for your contribution, and I apologize for the delay! As this change is very straight forward and reuses logic from the AuthJS provider, I think we can quickly push this through and release it in 0.8.0! Could you please fix the merge conflicts and then we can do a review and hopefully merge without any issues π |
β¦om/nojiritakeshi/nuxt-auth into feat/extends-addDefaultCallbackUrl
Hi @zoey-kaiser ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nojiritakeshi π
Sorry for the delay in the review, I have been pretty swamped lately π
Thanks for the awsome PR! Could you please look into making this new option configurable via the nuxt config, like with the authjs provider?
There we allow you to set addDefaultCallbackUrl
to a boolean to enable / disable automatic callback URL detection or hard code it to a string, which is then always the callback URL?
I think this would allow for more flexibility and would also match the other providers! Thank you so much π
Hi @zoey-kaiser π Indeed. I agree with that opinion. |
Hi @zoey-kaiser .
Therefore, I do not see the need to make a new correction to this point, do you? Please let me know if I am misguided! |
You are right! I revised this PR and agree! Sorry about the confusion! Thank you for your contribution! I will release this PR in |
π Linked issue
#622
#656
β Type of change
π Description
addDefaultCallback can now be set by refresh and local provider.
I have confirmed that it works in playground.
π Checklist