Refresh provider on tab refocus calls getSession instead of refresh

[mbellamyy]

Environment

---

• Operating System: Linux
• Node Version: v18.15.0
• Nuxt Version: 3.11.2
• CLI Version: 3.11.1
• Nitro Version: 2.9.6
• Package Manager: [email protected]
• Builder: -
• User Config: nitro, auth, components, imports, runtimeConfig, modules, pinia, security, build, css, app, robots, devtools
• Runtime Modules: [email protected], @nuxtjs/[email protected], @pinia/[email protected], @vueuse/[email protected], @nuxtjs/[email protected], @nuxt/[email protected], @sidebase/[email protected]
• Build Modules: -

---

Reproduction

not needed, code is obvious

Describe the bug

This is actually two issues.

First issue is here. Let's assume refresh provider is chosen.

nuxt-auth/src/runtime/utils/refreshHandler.ts

Lines 43 to 62 in faa039b

	if (enableRefreshPeriodically !== false) {
	const intervalTime =
	enableRefreshPeriodically === true ? 1000 : enableRefreshPeriodically
	this.refetchIntervalTimer = setInterval(() => {
	if (data.value) {
	getSession()
	}
	}, intervalTime)
	}
	if (runtimeConfig.provider.type === 'refresh') {
	const intervalTime = runtimeConfig.provider.token.maxAgeInSeconds! * 1000
	const { refresh, refreshToken } = useAuth()
	this.refreshTokenIntervalTimer = setInterval(() => {
	if (refreshToken.value) {
	refresh()
	}
	}, intervalTime)
	}

We're creating two intervals. One of them is calling getSession and the other is calling refresh. But the refresh implementation calls getSession at the end itself... So the first interval might be redundant for refresh? I know the interval times are different. So this is not a hugely imporant part of this issue.

Now the second (and more important) part of the issue:

nuxt-auth/src/runtime/utils/refreshHandler.ts

Lines 22 to 29 in faa039b

	visibilityHandler () {
	// Listen for when the page is visible, if the user switches tabs
	// and makes our tab visible again, re-fetch the session, but only if
	// this feature is not disabled.
	if (this.config?.enableRefreshOnWindowFocus && document.visibilityState === 'visible') {
	useAuth().getSession()
	}
	},

This function is the tab refocus refresher. It is calling getSession which is acceptable in the local provider, but for refresh I think it should call refresh, which in turn calls getSession later.
If the token is expired (but can be refreshed), this method is missing it and logging the user out.

Additional context

No response

Logs

No response

[ThomasSimonsen20]

@phoenix-ru Hey Phoenix sorry to ping, I see you started working on a PR regarding this, is this something you are still working on? I am facing a similar issue as above and I believe your PR would fix that issue :)

I am sadly not experienced enough to figure out if I could help with anything in your PR, as I can barely understand what's going on :D

[phoenix-ru]

Hi @ThomasSimonsen20 , I was on a vacation 🙂
I will possibly come back to this in 2 days or next week, as it's awaiting review from @zoey-kaiser

[ThomasSimonsen20]

Thank you for the update, hope you had a nice vacation :)

[zoey-kaiser]

Hi @mbellamyy and @ThomasSimonsen20 👋

Sorry for the ping, but I wanted to quickly let you know that we have just released https://github.com./sidebase/nuxt-auth/releases/tag/0.8.0-alpha.3 in which you can now define your own custom refresh logic! Feel free to check out the release notes for more information!