Skip to content

Intern the parts of Superpower used by this assembly #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 25, 2021

Conversation

nblumhardt
Copy link
Member

Working towards a version that can be integrated at a lower layer into the Serilog ecosystem - if not Serilog itself, then possibly by sinks like Console and File, or by metapackages like AspNetCore.

The sliver of Superpower used by this package is small, relative to Superpower itself; the LoC count of this PR is greatly inflated by license headers, XDOC, etc.; I'd guess there are ~500 significant LoC incoming.

Drafting the PR to check size stats.

@nblumhardt
Copy link
Member Author

Serilog.Expressions.dll 2.0: 132,608 bytes
Superpower.dll 3.0-dev: 91,648 bytes

Total assembly footprint today (net5.0) is 224,256 bytes.

Branch build for this PR, Serilog.Expressions.dll only: 171,008 bytes.

Cutting size isn't the main aim, but losing 23% is a nice side-benefit.

@nblumhardt nblumhardt marked this pull request as ready for review May 24, 2021 22:59
@nblumhardt nblumhardt merged commit 3dbc506 into serilog:dev May 25, 2021
@nblumhardt nblumhardt mentioned this pull request Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant