Skip to content

CreateCurlOptions method regression tests #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 27, 2018

Conversation

misantron
Copy link
Contributor

Resolves issue #94

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description:

  • Add tests for Client->createCurlOptions() method to prevent regressions in future.
  • Some code-style/doc-block/etc fixes

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Mar 13, 2018
@codecov
Copy link

codecov bot commented Mar 13, 2018

Codecov Report

Merging #95 into master will increase coverage by 4.04%.
The diff coverage is 65.62%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #95      +/-   ##
=========================================
+ Coverage   80.66%   84.7%   +4.04%     
=========================================
  Files           3       3              
  Lines         181     170      -11     
=========================================
- Hits          146     144       -2     
+ Misses         35      26       -9
Impacted Files Coverage Δ
lib/Response.php 100% <100%> (+3.57%) ⬆️
lib/Client.php 81.56% <63.33%> (+4.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08fe96a...a952b54. Read the comment docs.

@thinkingserious
Copy link
Contributor

Hi @misantron,

I found another regression that I've just fixed. Could you please fix the new conflict? Thanks!

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty type: twilio enhancement feature request on Twilio's roadmap labels Mar 23, 2018
@misantron
Copy link
Contributor Author

@thinkingserious Done

@thinkingserious
Copy link
Contributor

Thanks @misantron!

This is looking good, I've added this to our backlog for review.

With Best Regards,

Elmer

@thinkingserious thinkingserious merged commit c1682b1 into sendgrid:master Mar 27, 2018
@thinkingserious
Copy link
Contributor

Hello @misantron,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

thinkingserious added a commit that referenced this pull request Mar 27, 2018
CreateCurlOptions method regression tests
Falseclock pushed a commit to Falseclock/php-http-client that referenced this pull request Jan 30, 2019
CreateCurlOptions method regression tests
Falseclock pushed a commit to Falseclock/php-http-client that referenced this pull request Jan 30, 2019
CreateCurlOptions method regression tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants