Skip to content

feat: Add docker compose file for a containerized development environment #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from

Conversation

michaeljdennis
Copy link
Contributor

Fixes #49

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

This PR adds a docker compose file for a containerized development environment.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Nov 1, 2017
@thinkingserious
Copy link
Contributor

Hello @michaeljdennis,

When I try to run this, I get a

Recoverable fatal error: Object of class SendGrid\Client could not be converted to string in /php-http-client/examples/example.php on line 19

when I click on the example.php link from localhost:8080.

When you clicked on that link did you receive the right response?

With Best Regards,

Elmer

@michaeljdennis
Copy link
Contributor Author

Hi @thinkingserious. I will take a look and get back to you.

@thinkingserious
Copy link
Contributor

Awesome, thanks @michaeljdennis!

@codecov
Copy link

codecov bot commented Jan 29, 2018

Codecov Report

Merging #80 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #80   +/-   ##
=======================================
  Coverage   80.87%   80.87%           
=======================================
  Files           3        3           
  Lines         183      183           
=======================================
  Hits          148      148           
  Misses         35       35
Impacted Files Coverage Δ
lib/Client.php 77.33% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56d046a...9dcfe62. Read the comment docs.

@michaeljdennis
Copy link
Contributor Author

Hi @thinkingserious,

I looked into this a bit and found that some methods had been lost in a merge. I have re-added them in the commits above. Also, it appears that the master branch has errors that are similar to the one you reported when running the example file. All unit tests are passing though, so we may need to look into those. I have included fixes that allow the example file to be run successfully. Please let me know if it works for you now.

@thinkingserious
Copy link
Contributor

Awesome @michaeljdennis!

I've updated the status of this issue in our backlog.

@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty type: twilio enhancement feature request on Twilio's roadmap labels Feb 28, 2018
@childish-sambino childish-sambino removed the type: twilio enhancement feature request on Twilio's roadmap label Jul 20, 2020
@thinkingserious thinkingserious changed the base branch from master to main July 28, 2020 14:38
@thinkingserious thinkingserious changed the title Add docker compose file for a containerized development environment feat: Add docker compose file for a containerized development environment Nov 19, 2020
Copy link
Contributor

@thinkingserious thinkingserious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

When I try to run this, I get the following error:

int(403) string(56) "{"errors":[{"field":null,"message":"access forbidden"}]}"

int(403) string(56) "{"errors":[{"field":null,"message":"access forbidden"}]}"

int(403) string(56) "{"errors":[{"field":null,"message":"access forbidden"}]}"

int(403) string(56) "{"errors":[{"field":null,"message":"access forbidden"}]}"

int(403) string(56) "{"errors":[{"field":null,"message":"access forbidden"}]}"

int(403) string(56) "{"errors":[{"field":null,"message":"access forbidden"}]}"

int(403) string(56) "{"errors":[{"field":null,"message":"access forbidden"}]}"

@@ -370,26 +370,33 @@ private function buildUrl($queryParams = null)
*/
private function createCurlOptions($method, $body = null, $headers = null)
{
$options = [
$options = array_replace(
[
CURLOPT_RETURNTRANSFER => true,
CURLOPT_HEADER => true,
CURLOPT_CUSTOMREQUEST => strtoupper($method),
CURLOPT_SSL_VERIFYPEER => $this->verifySSLCerts,
CURLOPT_FAILONERROR => false,
] + $this->curlOptions;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing closing parenthesis.

@thinkingserious thinkingserious added status: waiting for feedback waiting for feedback from the submitter type: community enhancement feature request not on Twilio's roadmap and removed difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio labels Nov 19, 2020
@thinkingserious
Copy link
Contributor

Closing until PR feedback is addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting for feedback waiting for feedback from the submitter type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dockerize this repo!
3 participants