-
Notifications
You must be signed in to change notification settings - Fork 68
feat: Add docker compose file for a containerized development environment #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @michaeljdennis, When I try to run this, I get a Recoverable fatal error: Object of class SendGrid\Client could not be converted to string in /php-http-client/examples/example.php on line 19 when I click on the When you clicked on that link did you receive the right response? With Best Regards, Elmer |
Hi @thinkingserious. I will take a look and get back to you. |
Awesome, thanks @michaeljdennis! |
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
=======================================
Coverage 80.87% 80.87%
=======================================
Files 3 3
Lines 183 183
=======================================
Hits 148 148
Misses 35 35
Continue to review full report at Codecov.
|
Hi @thinkingserious, I looked into this a bit and found that some methods had been lost in a merge. I have re-added them in the commits above. Also, it appears that the master branch has errors that are similar to the one you reported when running the example file. All unit tests are passing though, so we may need to look into those. I have included fixes that allow the example file to be run successfully. Please let me know if it works for you now. |
Awesome @michaeljdennis! I've updated the status of this issue in our backlog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!
When I try to run this, I get the following error:
int(403) string(56) "{"errors":[{"field":null,"message":"access forbidden"}]}"
int(403) string(56) "{"errors":[{"field":null,"message":"access forbidden"}]}"
int(403) string(56) "{"errors":[{"field":null,"message":"access forbidden"}]}"
int(403) string(56) "{"errors":[{"field":null,"message":"access forbidden"}]}"
int(403) string(56) "{"errors":[{"field":null,"message":"access forbidden"}]}"
int(403) string(56) "{"errors":[{"field":null,"message":"access forbidden"}]}"
int(403) string(56) "{"errors":[{"field":null,"message":"access forbidden"}]}"
@@ -370,26 +370,33 @@ private function buildUrl($queryParams = null) | |||
*/ | |||
private function createCurlOptions($method, $body = null, $headers = null) | |||
{ | |||
$options = [ | |||
$options = array_replace( | |||
[ | |||
CURLOPT_RETURNTRANSFER => true, | |||
CURLOPT_HEADER => true, | |||
CURLOPT_CUSTOMREQUEST => strtoupper($method), | |||
CURLOPT_SSL_VERIFYPEER => $this->verifySSLCerts, | |||
CURLOPT_FAILONERROR => false, | |||
] + $this->curlOptions; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing closing parenthesis.
Closing until PR feedback is addressed. |
Fixes #49
Checklist
Short description of what this PR does:
This PR adds a docker compose file for a containerized development environment.