Skip to content

Create Dockerfile #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2018
Merged

Create Dockerfile #73

merged 1 commit into from
Jan 23, 2018

Conversation

jmauerhan
Copy link
Contributor

Fixes

Work on Issue #49

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • I have added a Dockerfile to allow local development in Docker for this repo. However, I'm not familiar with the repo so I'm not entirely sure this meets your needs, but hopefully it's a starting point.

Work on Issue #49
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 31, 2017
@jmauerhan
Copy link
Contributor Author

The documentation requested about how to run it would be:

  • build: docker build -t client .
  • run : docker run client php examples/example.php

But I'm not sure which .md file you wanted this in

@thinkingserious thinkingserious merged commit 4b308b0 into sendgrid:master Jan 23, 2018
@thinkingserious
Copy link
Contributor

Hello @jmauerhan,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Falseclock pushed a commit to Falseclock/php-http-client that referenced this pull request Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants