Adds unit test for checking file existence in repo #60
Conversation
thinkingserious
added
the
status: code review request
|
|
test/unit/FilesExistTest.php
Outdated
| $composeExists = file_exists('./docker-compose.yml') || file_exists('./docker/docker-compose.yml'); | ||
| $this->assertTrue($composeExists); | ||
|
|
||
| $dockerExists = file_exists('./Docker') || file_exists('./docker/Docker') |
There was a problem hiding this comment.
This line is missing a ; so I am adding it in :)
0.21s$ ../../vendor/bin/phpunit . --bootstrap bootstrap.php --filter test* --coverage-clover clover.xml
PHP Parse error: syntax error, unexpected '$this' (T_VARIABLE) in /home/travis/build/sendgrid/php-http-client/test/unit/FilesExistTest.php on line 28
mbernier
added
difficulty: medium
|
We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt. Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!) You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged. |
test/unit/FilesExistTest.php
Outdated
| { | ||
| public function testFileArePresentInRepo() | ||
| { | ||
| $this->assertFileExists('./.gitignore'); |
There was a problem hiding this comment.
There was 1 failure:
1) SendGrid\Test\FilesExistTest::testFileArePresentInRepo
Failed asserting that file "./.gitignore" exists.
/home/travis/build/sendgrid/php-http-client/test/unit/FilesExistTest.php:9
I am wondering if PHP is not checking the root directory, but in fact, checking the test file's directory?
Can you please try outputting the directory here to test and fixing the file paths accordingly?
There was a problem hiding this comment.
yup, will try to do it asap
|
If you are interested, we would love the opportunity to talk to you about Hacktoberfest and our API libraries. Our agenda would be: Explore what you liked and is there anything we can do to improve? You can grab a time on my calendar that works for you and we can have a chat on Google Hangout or Skype. If you prefer, you can email me using my GitHub username at my company’s domain. Thank you so much, Matt Bernier - @mbernier - SendGrid Developer Experience Product Manager |
|
@mbernier done! Let me know if this fixes the problem |
|
This is great, thanks for making the change!! |
|
Hello @micheleorselli, |
Adds unit test for checking file existence in repo
fixes #58