Skip to content

Disable CURLOPT_FAILONERROR #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2017
Merged

Disable CURLOPT_FAILONERROR #30

merged 1 commit into from
Oct 24, 2017

Conversation

ProZsolt
Copy link
Contributor

Fixes #18

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 11, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 11, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty hacktoberfest labels Oct 11, 2017
mbernier
mbernier approved these changes Oct 11, 2017
View reviewed changes
Copy link

@mbernier mbernier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a really good idea since we want the library to handle the 4xx and 5xx errors itself.

@thinkingserious thinkingserious mentioned this pull request Oct 22, 2017
Closed
@mbernier mbernier merged commit 7296014 into sendgrid:master Oct 24, 2017
@thinkingserious
Copy link
Contributor

Hello @ProZsolt,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@mbernier mbernier mentioned this pull request Oct 24, 2017
Closed
Falseclock pushed a commit to Falseclock/php-http-client that referenced this pull request Jan 30, 2019
Merge pull request sendgrid#30 from ProZsolt/master
25a3c19 
Disable CURLOPT_FAILONERROR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbernier mbernier mbernier approved these changes

Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ProZsolt @SendGridDX @thinkingserious @mbernier