Skip to content

implements sending concurrent requests with curl multi #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2017
Merged

implements sending concurrent requests with curl multi #24

merged 1 commit into from
Dec 16, 2017

Conversation

lightbringer1991
Copy link
Contributor

#hacktoberfest

This is an improvement as a partial answer to sendgrid/sendgrid-php#259

Allow requests to be sent concurrently.

Works exactly like the single request, but use curl_multi_ family.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 2, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 2, 2017

CLA assistant check
All committers have signed the CLA.

@thinkingserious thinkingserious added difficulty: hard fix is hard in difficulty hacktoberfest labels Oct 2, 2017
@thinkingserious
Copy link
Contributor

This is awesome @lightbringer1991!

Could you please fix up the conflicts so we can merge? Thanks!

With Best Regards,

Elmer

@lightbringer1991
Copy link
Contributor Author

hi, I have rebased with the latest master, could you please merge this PR, thank you.

@thinkingserious
Copy link
Contributor

@caseyw, @vitya1, @Braunson, @cbschuld, @paoga87, @Taluu, @mazanax, @ninsuo, @ianh2, @WadeShuler, @jaimehing, @KnightAR

If you have a moment, I'd appreciate some extra eyes on this EPIC PR :)

@thinkingserious
Copy link
Contributor

@lightbringer1991

We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt.

Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!)

You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!

Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged.

@ninsuo
Copy link

ninsuo commented Nov 2, 2017

whoops, I was notified by GitHub and thought you talked to me, I filled the form 😅
don't take it into account haha

@thinkingserious
Copy link
Contributor

No worries @ninsuo :)

Thanks for the heads up!

@thinkingserious
Copy link
Contributor

Hi @lightbringer1991,

Do you mind fixing these final conflicts so I can review and merge this in? Thank you!

With Best Regards,

Elmer

@codecov
Copy link

codecov bot commented Nov 29, 2017

Codecov Report

Merging #24 into master will increase coverage by 12.24%.
The diff coverage is 79.16%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #24       +/-   ##
===========================================
+ Coverage   70.43%   82.68%   +12.24%     
===========================================
  Files           3        3               
  Lines         115      179       +64     
===========================================
+ Hits           81      148       +67     
+ Misses         34       31        -3
Impacted Files Coverage Δ
lib/Client.php 79.45% <79.16%> (+19.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c47713...c48035d. Read the comment docs.

@lightbringer1991
Copy link
Contributor Author

I have rebased with master, however, I cannot seem to fix all the code climate issues (toggle between complexity and multiple returns violation)
I'm not sure if the code complexity is so high that it is unmaintainable in this case, so maybe we can still merge it?

@thinkingserious
Copy link
Contributor

Thank you @lightbringer1991!

I will review further and let you know my thoughts.

@thinkingserious thinkingserious merged commit 7865926 into sendgrid:master Dec 16, 2017
@thinkingserious
Copy link
Contributor

Hello @lightbringer1991,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@lightbringer1991 lightbringer1991 deleted the sendgrid-php-259-allow-sending-api-requests-in-bulk branch December 16, 2017 03:06
Falseclock pushed a commit to Falseclock/php-http-client that referenced this pull request Jan 30, 2019
…-allow-sending-api-requests-in-bulk

implements sending concurrent requests with curl multi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: hard fix is hard in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants