-
Notifications
You must be signed in to change notification settings - Fork 68
implements sending concurrent requests with curl multi #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implements sending concurrent requests with curl multi #24
Conversation
This is awesome @lightbringer1991! Could you please fix up the conflicts so we can merge? Thanks! With Best Regards, Elmer |
hi, I have rebased with the latest master, could you please merge this PR, thank you. |
We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt. Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!) You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged. |
whoops, I was notified by GitHub and thought you talked to me, I filled the form 😅 |
No worries @ninsuo :) Thanks for the heads up! |
Do you mind fixing these final conflicts so I can review and merge this in? Thank you! With Best Regards, Elmer |
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
===========================================
+ Coverage 70.43% 82.68% +12.24%
===========================================
Files 3 3
Lines 115 179 +64
===========================================
+ Hits 81 148 +67
+ Misses 34 31 -3
Continue to review full report at Codecov.
|
I have rebased with master, however, I cannot seem to fix all the code climate issues (toggle between complexity and multiple returns violation) |
Thank you @lightbringer1991! I will review further and let you know my thoughts. |
Hello @lightbringer1991, |
…-allow-sending-api-requests-in-bulk implements sending concurrent requests with curl multi
#hacktoberfest
This is an improvement as a partial answer to sendgrid/sendgrid-php#259
Allow requests to be sent concurrently.
Works exactly like the single request, but use
curl_multi_
family.