Skip to content

test: test enhancements #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 13, 2020
Merged

Conversation

peter279k
Copy link
Contributor

Resolves #119.

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Test enhancement.

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 13, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 13, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 13, 2018

Codecov Report

Merging #120 into master will decrease coverage by 3.75%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #120      +/-   ##
============================================
- Coverage     88.00%   84.24%   -3.76%     
- Complexity        0       56      +56     
============================================
  Files             4        2       -2     
  Lines           175      165      -10     
============================================
- Hits            154      139      -15     
- Misses           21       26       +5     
Impacted Files Coverage Δ Complexity Δ
lib/Client.php 81.56% <0.00%> (-3.76%) 47.00% <0.00%> (+47.00%) ⬇️
test/unit/MockClient.php
lib/Exception/InvalidRequest.php

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd727b9...9aea2bb. Read the comment docs.

@childish-sambino childish-sambino changed the title Test enhancement test: test enhancements Jul 13, 2020
Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@childish-sambino childish-sambino merged commit a5e3cef into sendgrid:master Jul 13, 2020
@peter279k peter279k deleted the issue_#119 branch July 13, 2020 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test enhancement
4 participants