-
Notifications
You must be signed in to change notification settings - Fork 68
Only mention the lowest required PHP version in README #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #106 +/- ##
======================================
Coverage 84.7% 84.7%
======================================
Files 3 3
Lines 170 170
======================================
Hits 144 144
Misses 26 26 Continue to review full report at Codecov.
|
Hello @svenluijten, |
Hello @svenluijten, |
Hello @svenluijten, |
Only mention the lowest required PHP version in README
Checklist
I have added tests that prove my fix is effective or that my feature worksI have added necessary documentation about the functionality in the appropriate .md fileI have added in line documentation to the code I modifiedShort description of what this PR does:
This PR makes sure the README mirrors what is actually required in the code. As per the
composer.json
, this library requires PHP 5.6 or higher. Let's not confuse users by only mentioning PHP 5.6 and 7.0 in the README.