Skip to content

Add Code Review to Contributing.md #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
thinkingserious opened this issue Oct 31, 2017 · 1 comment
Closed

Add Code Review to Contributing.md #76

thinkingserious opened this issue Oct 31, 2017 · 1 comment
Labels
difficulty: easy fix is easy in difficulty

Comments

@thinkingserious
Copy link
Contributor

  • Add a "Code Reviews" section on CONTRIBUTING.md
  • Put the following under the header:

If you can, please look at open PRs and review them. Give feedback and help us merge these PRs much faster! If you don't know how, Github has some great information on how to review a Pull Request.

  • Link the header in the Contributing.md Table of Contents
  • Add a link to the README.md file: Review Pull Requests under "Contributing Section"
@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty hacktoberfest labels Oct 31, 2017
@Pawka
Copy link
Contributor

Pawka commented Oct 31, 2017

I'm on this.

@Pawka Pawka mentioned this issue Oct 31, 2017
Merged
6 tasks
thinkingserious added a commit that referenced this issue Jan 23, 2018
@thinkingserious
Merge pull request #78 from Pawka/patch-1
0d23d92 
Added Pull Requests Review section to CONTRIBUTE.md Closes #76
Falseclock pushed a commit to Falseclock/php-http-client that referenced this issue Jan 30, 2019
@Pawka
Added "Code Reviews" section. Fixes sendgrid#76
8712c62
Falseclock pushed a commit to Falseclock/php-http-client that referenced this issue Jan 30, 2019
@thinkingserious
Merge pull request sendgrid#78 from Pawka/patch-1
be0e533 
Added Pull Requests Review section to CONTRIBUTE.md Closes sendgrid#76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Pawka @thinkingserious