collect autoloading deprecations before running testCase

[soyuka]

When one triggers a deprecation in a class directly like this:

<?php
trigger_error('Depreciated interface', E_USER_DEPRECATED);

interface Foo {}

This technique is notably used in many Symfony components, for example:

https://github.com./symfony/symfony/blob/82cf90aefb7e9117ebd981fec83d7546e310e52b/src/Symfony/Component/PropertyInfo/Type.php#L12-L15

The deprecation will be triggered when autoloading the class, which happens in:

phpunit/src/TextUI/Application.php

Line 181 in 4b6a4ee

$testSuite = $this->buildTestSuite($configuration);

At that point, the ErrorHandler is not registered and we loose the deprecation.

This pull request gives an idea on how it may be fixed, indeed the ErrorHandler needs a TestCase therefore I'm collecting these deprecations and triggering them once we call ErrorHandler::enable. I'm open to suggestions on how to fix this differently. Obviously I'll add tests if/once a solution is found that can be merged.

Thanks!

[sebastianbergmann]

The name of this variable should be $deprecations.

[sebastianbergmann]

The name of this method should be collectGlobalDeprecations.

[sebastianbergmann]

I think this idea is worthwhile to pursue. Please fix the existing tests and add new tests to cover the changed/added functionality.

I do not consider this to be a bug fix, so this pull request should target the main branch instead of 11.5.

[soyuka]

#5844 link

I updated the code, interestingly this conflicts with the resolution of #5844 (https://github.com./sebastianbergmann/phpunit/commit/8e8776083c71277fa90403b183530c956b110b60). To mitigate this I need to use something like:

phpunit/src/Framework/TestCase.php

Lines 1598 to 1610 in dd3bb4b

	while (true) {
	$previousHandler = set_error_handler(static fn () => false);
	restore_error_handler();
	if ($previousHandler === null) {
	break;
	}
	$activeErrorHandlers[] = $previousHandler;
	restore_error_handler();
	}

The idea would be to restore only the handler that we set to avoid restoring another handler registered by third party (bootstrap or test suite configuration).

The handler that's created in the bootstrap.php of 5844 fails once restored as it's a private method... I also think it makes the code slightly more complicated then what I would like (see failure at https://github.com./sebastianbergmann/phpunit/actions/runs/14144107940/job/39629361311?pr=6165)

[soyuka]

This reflects what happens when loading classes usually, if we do the same as in #5844 we'll trigger the deprecation during the loadBootstrapScript.

[TimWolla]

Did you test this with OPcache? I came across this PR on my phone and php/php-src#17422 sounds relevant.

[soyuka]

I don't use opcache