-
Notifications
You must be signed in to change notification settings - Fork 46
feat(config): add a commented configuration file #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
remyleone
merged 9 commits into
scaleway:master
from
remyleone:config_file_with_comments
Nov 29, 2019
Merged
feat(config): add a commented configuration file #231
remyleone
merged 9 commits into
scaleway:master
from
remyleone:config_file_with_comments
Nov 29, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Nov 8, 2019
2d1242d
to
9d7f392
Compare
9d7f392
to
d082740
Compare
QuentinBrosse
suggested changes
Nov 13, 2019
f32a4b6
to
6bde5c5
Compare
golangcibot
reviewed
Nov 26, 2019
6bde5c5
to
480a330
Compare
golangcibot
reviewed
Nov 26, 2019
d836a79
to
60b2eea
Compare
golangcibot
reviewed
Nov 27, 2019
ca39ac1
to
38e48fb
Compare
golangcibot
reviewed
Nov 27, 2019
kindermoumoute
requested changes
Nov 27, 2019
6d636d9
to
b403bd5
Compare
QuentinBrosse
suggested changes
Nov 28, 2019
496fd26
to
1fead78
Compare
1fead78
to
64641f9
Compare
golangcibot
reviewed
Nov 28, 2019
QuentinBrosse
suggested changes
Nov 28, 2019
kindermoumoute
requested changes
Nov 28, 2019
kindermoumoute
requested changes
Nov 29, 2019
kindermoumoute
approved these changes
Nov 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This is great work! 👍
@kindermoumoute Thanks for the reviews :) |
QuentinBrosse
approved these changes
Nov 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.