Skip to content

feat(config): add a commented configuration file #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 29, 2019

Conversation

remyleone
Copy link
Member

No description provided.

@remyleone remyleone self-assigned this Nov 8, 2019
@remyleone remyleone force-pushed the config_file_with_comments branch from 2d1242d to 9d7f392 Compare November 8, 2019 17:20
@remyleone remyleone force-pushed the config_file_with_comments branch from 9d7f392 to d082740 Compare November 13, 2019 10:44
@remyleone remyleone force-pushed the config_file_with_comments branch 2 times, most recently from f32a4b6 to 6bde5c5 Compare November 26, 2019 15:45
@remyleone remyleone force-pushed the config_file_with_comments branch from 6bde5c5 to 480a330 Compare November 26, 2019 17:21
@remyleone remyleone force-pushed the config_file_with_comments branch 3 times, most recently from d836a79 to 60b2eea Compare November 27, 2019 14:32
@remyleone remyleone force-pushed the config_file_with_comments branch 2 times, most recently from ca39ac1 to 38e48fb Compare November 27, 2019 15:49
@remyleone remyleone changed the title WIP: Add a commented configuration file Add a commented configuration file Nov 27, 2019
@remyleone remyleone changed the title Add a commented configuration file feat(config): add a commented configuration file Nov 27, 2019
@remyleone remyleone force-pushed the config_file_with_comments branch 3 times, most recently from 6d636d9 to b403bd5 Compare November 27, 2019 17:03
@remyleone remyleone force-pushed the config_file_with_comments branch 3 times, most recently from 496fd26 to 1fead78 Compare November 28, 2019 13:11
@remyleone remyleone force-pushed the config_file_with_comments branch from 1fead78 to 64641f9 Compare November 28, 2019 13:56
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is great work! 👍

@remyleone
Copy link
Member Author

@kindermoumoute Thanks for the reviews :)

Copy link
Contributor

@QuentinBrosse QuentinBrosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@remyleone remyleone merged commit a32c9bd into scaleway:master Nov 29, 2019
@remyleone remyleone deleted the config_file_with_comments branch October 5, 2021 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants