Skip to content

Solution article for 2024 day 02 #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Conversation

spamegg1
Copy link

@spamegg1 spamegg1 commented Dec 2, 2024

Here is a convenient Scastie of the solution.

@SethTisue SethTisue merged commit 1157b36 into scalacenter:website Dec 2, 2024
@SethTisue
Copy link
Collaborator

thank you!!

@SethTisue
Copy link
Collaborator

hmm, should I not have merged this until tomorrow? 🤔 @bishabosha ?

@bishabosha
Copy link
Member

bishabosha commented Dec 2, 2024

For avoiding spoilers? I don't think we had any policy before like that.

But it could be good to start

@bishabosha
Copy link
Member

it would be cool if there was some react/docusaurus package for spoiler tags (combined with a date filter?)

@SethTisue
Copy link
Collaborator

an argument for merging promptly is that then the page is available for community folks to add their links to

I think that probably outweighs any spoiler concerns

@bishabosha
Copy link
Member

the page is already there in the morning when the cron job bot creates it about few mins after the challenge goes live

@bishabosha
Copy link
Member

anyway I did find this interesting package https://github.com./abdullahtariq1171/react-spoiler, which I guess could put the whole article sandwich between spoiler tags

@SethTisue
Copy link
Collaborator

SethTisue commented Dec 2, 2024

the page is already there in the morning when the cron job bot creates it about few mins after the challenge goes live

oh, okay. in that case, I will try to remember to hold off on merging these PRs until the following day. it also gives more time for review, anyway

@SethTisue SethTisue mentioned this pull request Dec 11, 2024
@SethTisue SethTisue mentioned this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants