Tests ensuring the server integrity when running third-party code #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small suite of tests for ensuring that the deployed docker container works, and does not leak any more information that it is needed.
I've included three simple tests:
System.exit
sys.env
If you can think of other tests, please let me know.
I've kept these tests separate from other endpoint tests in the code as this is really to make sure that the endpoint works, rather than the functionality of the endpoint itself.
--
These tests sit in their own SBT package, and are currently not run as part of any automated build. Due to Docker on Heroku being in beta and still very new, it is not possible to use Heroku's deployment pipelines with Docker yet. I think we have a few options here as to what to do with them.
Once Heroku can deploy pipelines of Docker containers, we should definitely move over to using that.
@raulraja Thoughts? I think setting our own pipeline wouldn't take very long and I'm all for no manual intervention, but as I'd be hand-rolling this, I just wanted to see what you think before I go down this route.
Resolves #39.