Do not suppress the compile error code when generating sourcemaps #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the error return code of output can be suppressed if sourcemaps are generated. Even if this is can not be the case because if the compiler fails there may not be any source map data, it at least looks suspect.
rototor
changed the title
12 tasks
mgreter
added a commit
that referenced
this pull request
Dec 22, 2014
…odes Do not suppress the compile error code when generating sourcemaps
|
Thanks, looks like this was overlooked when updating to the new API! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the error return code of output can be suppressed if
sourcemaps are generated. Even if this is can not be the case because
if the compiler fails there may not be any source map data, it at least
looks suspect.