-
Notifications
You must be signed in to change notification settings - Fork 923
Use absolute_path instead of fs::canonicalize #4131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use absolute_path instead of fs::canonicalize #4131
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I am still not sure this will work in all cases, but I will merge this for now. |
@topecongiro , this will likely fail for deep paths even on later version Windows 10 installations. The removal of the MAX_PATH (~260 characters) limitation is opt-in and has to have a registry value set (see https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#enable-long-paths-in-windows-10-version-1607-and-later). That's an impossible bar to expect from any significant user population. It can't really be counted on at all. However, there is an available solution... extended-paths. Extended-paths (marked by a leading I referenced the needed solution for this in the original issue/PR. This type of path construction can even be used to access windows wierdo reserved paths like Please see the |
@rivy Hmm, I will take a look again, but the |
This PR is a successor of #3590.