Skip to content

diagnostics: suggest missing comma in bad FRU syntax #94939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2022
Merged

diagnostics: suggest missing comma in bad FRU syntax #94939

merged 1 commit into from
Mar 28, 2022

Conversation

notriddle
Copy link
Contributor

Fixes #51103

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 14, 2022
@rust-highfive
Copy link
Contributor

r? @cjgillot

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 14, 2022
cjgillot
cjgillot approved these changes Mar 26, 2022
View reviewed changes
Copy link
Contributor

@cjgillot cjgillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a syntactic nit.
r=me either way.

@notriddle notriddle force-pushed the notriddle/fru-comma-suggestion branch from 7dde66b to 301fc07 Compare March 27, 2022 17:01
@notriddle
Copy link
Contributor Author

@bors r=cjgillot

@bors
Copy link
Collaborator

bors commented Mar 27, 2022

📌 Commit 301fc07 has been approved by cjgillot

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 27, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Mar 27, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 27, 2022
@bors
Auto merge of rust-lang#95382 - Dylan-DPC:rollup-bebyfd1, r=Dylan-DPC
6252304 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#94939 (diagnostics: suggest missing comma in bad FRU syntax)
 - rust-lang#95120 (Implement `apply_switch_int_edge_effects` for backward analyses)
 - rust-lang#95364 (Add long error explanation for E0667)
 - rust-lang#95366 (Remove test files with duplicated checksums)
 - rust-lang#95368 (Fix typo in `String::try_reserve_exact` docs)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 726cd73 into rust-lang:master Mar 28, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 28, 2022
@notriddle notriddle deleted the notriddle/fru-comma-suggestion branch March 28, 2022 02:11
@pierwill pierwill mentioned this pull request May 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjgillot cjgillot cjgillot approved these changes

Assignees

@cjgillot cjgillot

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.

Diagnostic could be more helpful for missing comma when using .. field initialization copy operator.
5 participants
@notriddle @rust-highfive @bors @cjgillot @rustbot