Use const-checking to forbid use of unstable features in const-stable functions #76807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
`const_mut_refs` doesn't actually work in a `const` or `static`
ecstatic-morse
force-pushed
the
const-checking-staged-api
branch
from
589e285 to
abc7167
Compare
|
This is a good safety net for the actual changes! @bors r+ |
|
📌 Commit abc7167 has been approved by |
bors
added
S-waiting-on-bors
This was referenced Sep 19, 2020
This was referenced Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step towards #76618.
Currently this code isn't ever hit because
qualify_min_const_fnruns first and catches pretty much everything. One exception isconst_precise_live_drops, which does not use the newly added code since it runs as part of a separate pass.Also contains some unrelated refactoring, which is split into separate commits.
r? @oli-obk