Skip to content

triagebot: roll compiler reviewers for rustc/unstable book #139521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2025
Merged

triagebot: roll compiler reviewers for rustc/unstable book #139521

merged 1 commit into from
Apr 10, 2025

Conversation

jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented Apr 8, 2025

r? compiler

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 8, 2025
@rustbot
Copy link
Collaborator

rustbot commented Apr 8, 2025

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@jieyouxu
Copy link
Member Author

jieyouxu commented Apr 8, 2025

cc @GuillaumeGomez since I think I noticed you having to reroll platform support doc PRs way too frequently :D

@GuillaumeGomez
Copy link
Member

Thank you! T_T

Contribute once and become reviewer forever. 🤣

@jieyouxu
Copy link
Member Author

jieyouxu commented Apr 8, 2025

hehe

@jieyouxu
Copy link
Member Author

jieyouxu commented Apr 8, 2025

This is just a triagebot change so
@bors r=@GuillaumeGomez rollup

@bors
Copy link
Collaborator

bors commented Apr 8, 2025

📌 Commit e459db2 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 8, 2025
@jieyouxu jieyouxu assigned GuillaumeGomez and unassigned estebank Apr 8, 2025
@jieyouxu
Copy link
Member Author

jieyouxu commented Apr 8, 2025

Technically unstable-book also has library/language features, but at least compiler is more likely to be the right set of reviewers.

@ehuss
Copy link
Contributor

ehuss commented Apr 8, 2025

I'd like to stay a reviewer on /src/doc/rustc since I've written a lot of content there. Also, please CC me when removing me from rotation.

@jieyouxu
Copy link
Member Author

jieyouxu commented Apr 8, 2025

Oh yeah sorry
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 8, 2025
@jieyouxu
Copy link
Member Author

jieyouxu commented Apr 8, 2025

Right, a more specific directory will remove u from rotation...

@jieyouxu jieyouxu force-pushed the compiler-doc-reviewers branch 2 times, most recently from 11eadf5 to cbf4da2 Compare April 8, 2025 13:58
@jieyouxu
Copy link
Member Author

jieyouxu commented Apr 8, 2025 •
edited
Loading

@ehuss sorry about that, didn't mean to remove you from rotation. Does the revised entries correctly preserve you on rotation (for unstable-book as well)?

@jieyouxu
Copy link
Member Author

jieyouxu commented Apr 8, 2025

r? @ehuss
@rustbot ready

@rustbot rustbot assigned ehuss and unassigned GuillaumeGomez Apr 8, 2025
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 8, 2025
ehuss
ehuss reviewed Apr 8, 2025
View reviewed changes
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to approve with the suggestion applied.

Thinking more, the chances that I'll get assigned amongst the entire compiler team is vanishingly small since there are so few PRs and so many reviewers. But I'm fine with that I think.

@jieyouxu
Copy link
Member Author

jieyouxu commented Apr 8, 2025

Thinking more, the chances that I'll get assigned amongst the entire compiler team is vanishingly small since there are so few PRs and so many reviewers. But I'm fine with that I think.

Hm yeah. Maybe a triagebot mention but that is potentially quite noisy.

@jieyouxu jieyouxu added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 8, 2025
@ehuss
Copy link
Contributor

ehuss commented Apr 8, 2025

Yea, don't worry about it. I see the titles of most new PRs and can peek if I care.

@jieyouxu jieyouxu force-pushed the compiler-doc-reviewers branch from cbf4da2 to 616406d Compare April 8, 2025 23:38
@jieyouxu
Copy link
Member Author

jieyouxu commented Apr 8, 2025 •
edited
Loading

Changed unstable-book entry as requested.
@bors r=GuillaumeGomez,ehuss rollup

@bors
Copy link
Collaborator

bors commented Apr 8, 2025

📌 Commit 616406d has been approved by GuillaumeGomez,ehuss

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 8, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 9, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 9, 2025
@bors
Auto merge of rust-lang#139595 - matthiaskrgr:rollup-kaa8aim, r=matth…
51548ce 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#138470 (Test interaction between RFC 2229 migration and use closures)
 - rust-lang#138628 (Add more ergonomic clone tests)
 - rust-lang#139164 (std: improve documentation for get_mut() methods regarding forgotten guards)
 - rust-lang#139488 (Add missing regression GUI test)
 - rust-lang#139489 (compiletest: Add directive `dont-require-annotations`)
 - rust-lang#139513 (Report higher-ranked trait error when higher-ranked projection goal fails in new solver)
 - rust-lang#139521 (triagebot: roll compiler reviewers for rustc/unstable book)
 - rust-lang#139532 (Update `u8`-to-and-from-`i8` suggestions.)
 - rust-lang#139551 (report call site of inlined scopes for large assignment lints)
 - rust-lang#139575 (Remove redundant words)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 78e59af into rust-lang:master Apr 10, 2025
6 checks passed
@rustbot rustbot added this to the 1.88.0 milestone Apr 10, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 10, 2025
@rust-timer
Unrolled build for rust-lang#139521
7dc8e0d 
Rollup merge of rust-lang#139521 - jieyouxu:compiler-doc-reviewers, r=GuillaumeGomez,ehuss

triagebot: roll compiler reviewers for rustc/unstable book

r? compiler
@jieyouxu jieyouxu deleted the compiler-doc-reviewers branch April 10, 2025 01:42
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Apr 19, 2025
@bors
Auto merge of rust-lang#139595 - matthiaskrgr:rollup-kaa8aim, r=matth…
1e4dce6 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#138470 (Test interaction between RFC 2229 migration and use closures)
 - rust-lang#138628 (Add more ergonomic clone tests)
 - rust-lang#139164 (std: improve documentation for get_mut() methods regarding forgotten guards)
 - rust-lang#139488 (Add missing regression GUI test)
 - rust-lang#139489 (compiletest: Add directive `dont-require-annotations`)
 - rust-lang#139513 (Report higher-ranked trait error when higher-ranked projection goal fails in new solver)
 - rust-lang#139521 (triagebot: roll compiler reviewers for rustc/unstable book)
 - rust-lang#139532 (Update `u8`-to-and-from-`i8` suggestions.)
 - rust-lang#139551 (report call site of inlined scopes for large assignment lints)
 - rust-lang#139575 (Remove redundant words)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehuss ehuss ehuss left review comments

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@ehuss ehuss

Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.88.0
Development

Successfully merging this pull request may close these issues.
6 participants
@jieyouxu @rustbot @GuillaumeGomez @bors @ehuss @estebank