Skip to content

Add opt-level = "s" for more std symbolication crates #139215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2025
Merged

Add opt-level = "s" for more std symbolication crates #139215

merged 1 commit into from
Apr 2, 2025

Conversation

clubby789
Copy link
Contributor

This reduces the size of a hello world binary built by stage 1 in release by a few kilobytes

@rustbot
Copy link
Collaborator

rustbot commented Apr 1, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 1, 2025
@clubby789
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 1, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 1, 2025
@bors
Auto merge of rust-lang#139215 - clubby789:std-size-tweaks, r=<try>
16fa9f3 
Add `opt-level = "s"` for more std symbolication crates

This reduces the size of a hello world binary built by stage 1 in release by a few kilobytes
@bors
Copy link
Collaborator

bors commented Apr 1, 2025

⌛ Trying commit 312694a with merge 16fa9f3...

@bors
Copy link
Collaborator

bors commented Apr 1, 2025

☀️ Try build successful - checks-actions
Build commit: 16fa9f3 (16fa9f3af0cf724a9a40ab95862c3ad0c75239d1)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (16fa9f3): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.9% [-1.0%, -0.9%] 4
Improvements ✅
(secondary)		 -1.4% [-1.4%, -1.4%] 1
All ❌✅ (primary) -0.9% [-1.0%, -0.9%] 4

Max RSS (memory usage)

Results (primary -0.7%, secondary -2.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 5.0% [5.0%, 5.0%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.6% [-2.8%, -2.4%] 3
Improvements ✅
(secondary)		 -2.0% [-2.0%, -2.0%] 1
All ❌✅ (primary) -0.7% [-2.8%, 5.0%] 4

Cycles

Results (primary -0.8%, secondary 2.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.2% [2.2%, 2.2%] 1
Improvements ✅
(primary)		 -0.8% [-0.8%, -0.8%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.8% [-0.8%, -0.8%] 1

Binary size

Results (primary -0.4%, secondary -1.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.0% [0.0%, 0.0%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.4% [-2.1%, -0.0%] 40
Improvements ✅
(secondary)		 -1.8% [-2.1%, -0.2%] 45
All ❌✅ (primary) -0.4% [-2.1%, 0.0%] 41

Bootstrap: 774.818s -> 774.26s (-0.07%)
Artifact size: 365.93 MiB -> 365.92 MiB (-0.00%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 1, 2025
@joboet
Copy link
Member

joboet commented Apr 2, 2025 •
edited
Loading

Great! Binary and cycle improvements and no regressions!

@bors r+ rollup
r? joboet

@bors
Copy link
Collaborator

bors commented Apr 2, 2025

📌 Commit 4c92418 has been approved by joboet

It is now in the queue for this repository.

@rustbot rustbot assigned joboet and unassigned Mark-Simulacrum Apr 2, 2025
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2025
@TaKO8Ki TaKO8Ki mentioned this pull request Apr 2, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 2, 2025
@bors
Auto merge of rust-lang#139257 - TaKO8Ki:rollup-vjzdas7, r=TaKO8Ki
4f0de4c 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#139178 (Remove cjgillot from automated review assignment)
 - rust-lang#139184 (Add unstable `--print=crate-root-lint-levels`)
 - rust-lang#139215 (Add `opt-level = "s"` for more std symbolication crates)
 - rust-lang#139232 (Move methods from `Map` to `TyCtxt`, part 5.)
 - rust-lang#139239 (Remove `aux_build` run-make rustc helpers)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5df0c68 into rust-lang:master Apr 2, 2025
6 checks passed
@rustbot rustbot added this to the 1.88.0 milestone Apr 2, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 2, 2025
@rust-timer
Unrolled build for rust-lang#139215
17108a4 
Rollup merge of rust-lang#139215 - clubby789:std-size-tweaks, r=joboet

Add `opt-level = "s"` for more std symbolication crates

This reduces the size of a hello world binary built by stage 1 in release by a few kilobytes
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Apr 4, 2025
@TaKO8Ki
Rollup merge of rust-lang#139215 - clubby789:std-size-tweaks, r=joboet
408585e 
Add `opt-level = "s"` for more std symbolication crates

This reduces the size of a hello world binary built by stage 1 in release by a few kilobytes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Urgau Urgau Urgau left review comments

Assignees

@joboet joboet

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.88.0
Development

Successfully merging this pull request may close these issues.
7 participants
@clubby789 @rustbot @rust-timer @bors @joboet @Urgau @Mark-Simulacrum