Skip to content

Expect an array when expected and acutal types are both arrays during cast #138962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 14, 2025
Merged

Expect an array when expected and acutal types are both arrays during cast #138962

merged 2 commits into from
Apr 14, 2025

Conversation

xizheyin
Copy link
Contributor

@xizheyin xizheyin commented Mar 26, 2025 •
edited
Loading

Closes #138836

@rustbot
Copy link
Collaborator

rustbot commented Mar 26, 2025

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 26, 2025
compiler-errors
compiler-errors requested changes Mar 26, 2025
View reviewed changes
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write a description for why this code fixes the issue and especially why it's not going to affect existing code.

My first reaction to this code is definitely not the right way to fix a diagnostics issue, since it is code that is exercised even when there are no failures.

@compiler-errors
Copy link
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 26, 2025
@xizheyin
Copy link
Contributor Author

xizheyin commented Mar 26, 2025 •
edited
Loading

This is the handling of special circumstances. But I missed one condition.

This function checks when cast &m_expr as *const m_cast.

If the type m_expr is [ty1; N] and the type m_cast is [ty2; M], where M!=N, and ty1 is not [ty2; M], we need to use [ty1; N] instead of ty1 as the expected type.

The example is shown in the corresponding issue and the ui test newly added.

In this case, the code before and after modification will definitely report an error, so it will not affect the original logic. @compiler-errors

@xizheyin xizheyin requested a review from compiler-errors April 2, 2025 05:16
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 2, 2025
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 13, 2025

📌 Commit a34c42f has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 13, 2025
ChrisDenton added a commit to ChrisDenton/rust that referenced this pull request Apr 13, 2025
@ChrisDenton
Rollup merge of rust-lang#138962 - xizheyin:issue-138836, r=compiler-…
eb51b5e 
…errors

Expect an array when expected and acutal types are both arrays during cast

Closes rust-lang#138836
@ChrisDenton ChrisDenton mentioned this pull request Apr 13, 2025
Closed
ChrisDenton added a commit to ChrisDenton/rust that referenced this pull request Apr 13, 2025
@ChrisDenton
Rollup merge of rust-lang#138962 - xizheyin:issue-138836, r=compiler-…
8bed0ba 
…errors

Expect an array when expected and acutal types are both arrays during cast

Closes rust-lang#138836
@ChrisDenton ChrisDenton mentioned this pull request Apr 13, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 13, 2025
@bors
Auto merge of rust-lang#139755 - ChrisDenton:rollup-cl1ied1, r=ChrisD…
15ebec2 
…enton

Rollup of 12 pull requests

Successful merges:

 - rust-lang#138744 (Add methods to TCP and UDP sockets to modify hop limit (refresh of rust-lang#94678))
 - rust-lang#138962 (Expect an array when expected and acutal types are both arrays during cast)
 - rust-lang#139001 (add `naked_functions_rustic_abi` feature gate)
 - rust-lang#139379 (Use delayed bug for normalization errors in drop elaboration)
 - rust-lang#139582 (Various coercion cleanups)
 - rust-lang#139628 (Suggest remove redundant `$()?` around `vis`)
 - rust-lang#139644 (Micro-optimize `InstSimplify`'s `simplify_primitive_clone`)
 - rust-lang#139666 (cleanup `mir_borrowck`)
 - rust-lang#139674 (In `rustc_mir_transform`, iterate over index newtypes instead of ints)
 - rust-lang#139695 (compiletest: consistently use `camino::{Utf8Path,Utf8PathBuf}` throughout)
 - rust-lang#139722 (Move some things to rustc_type_ir)
 - rust-lang#139740 (Convert `tests/ui/lint/dead-code/self-assign.rs` to a known-bug test)

r? `@ghost`
`@rustbot` modify labels: rollup
jhpratt added a commit to jhpratt/rust that referenced this pull request Apr 13, 2025
@jhpratt
Rollup merge of rust-lang#138962 - xizheyin:issue-138836, r=compiler-…
e50d948 
…errors

Expect an array when expected and acutal types are both arrays during cast

Closes rust-lang#138836
@jhpratt jhpratt mentioned this pull request Apr 13, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 13, 2025
@bors
Auto merge of rust-lang#139761 - jhpratt:rollup-tki77or, r=jhpratt
4a9013e 
Rollup of 11 pull requests

Successful merges:

 - rust-lang#137043 (Initial `UnsafePinned` implementation [Part 1: Libs])
 - rust-lang#138962 (Expect an array when expected and acutal types are both arrays during cast)
 - rust-lang#139001 (add `naked_functions_rustic_abi` feature gate)
 - rust-lang#139379 (Use delayed bug for normalization errors in drop elaboration)
 - rust-lang#139582 (Various coercion cleanups)
 - rust-lang#139628 (Suggest remove redundant `$()?` around `vis`)
 - rust-lang#139644 (Micro-optimize `InstSimplify`'s `simplify_primitive_clone`)
 - rust-lang#139671 (Proc macro span API redesign: Replace proc_macro::SourceFile by Span::{file, local_file})
 - rust-lang#139674 (In `rustc_mir_transform`, iterate over index newtypes instead of ints)
 - rust-lang#139740 (Convert `tests/ui/lint/dead-code/self-assign.rs` to a known-bug test)
 - rust-lang#139741 (fix smir's run! doc and import)

r? `@ghost`
`@rustbot` modify labels: rollup
@jhpratt jhpratt mentioned this pull request Apr 13, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 14, 2025
@bors
Auto merge of rust-lang#139766 - jhpratt:rollup-afrfmnk, r=jhpratt
15f58c4 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#137043 (Initial `UnsafePinned` implementation [Part 1: Libs])
 - rust-lang#138962 (Expect an array when expected and acutal types are both arrays during cast)
 - rust-lang#139001 (add `naked_functions_rustic_abi` feature gate)
 - rust-lang#139379 (Use delayed bug for normalization errors in drop elaboration)
 - rust-lang#139582 (Various coercion cleanups)
 - rust-lang#139628 (Suggest remove redundant `$()?` around `vis`)
 - rust-lang#139644 (Micro-optimize `InstSimplify`'s `simplify_primitive_clone`)
 - rust-lang#139674 (In `rustc_mir_transform`, iterate over index newtypes instead of ints)
 - rust-lang#139740 (Convert `tests/ui/lint/dead-code/self-assign.rs` to a known-bug test)
 - rust-lang#139741 (fix smir's run! doc and import)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 60c76b9 into rust-lang:master Apr 14, 2025
6 checks passed
@rustbot rustbot added this to the 1.88.0 milestone Apr 14, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 14, 2025
@rust-timer
Unrolled build for rust-lang#138962
6d8b4b6 
Rollup merge of rust-lang#138962 - xizheyin:issue-138836, r=compiler-errors

Expect an array when expected and acutal types are both arrays during cast

Closes rust-lang#138836
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors Awaiting requested review from compiler-errors

Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.88.0
Development

Successfully merging this pull request may close these issues.

Confusing error message when coercing an array reference to a pointer of the wrong type
5 participants
@xizheyin @rustbot @compiler-errors @bors @fee1-dead